This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Deprecate/remove captureQuery #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LewisJEllis
force-pushed
the
breadcrumbs
branch
from
0fbccc1 to
461ec68
Compare
LewisJEllis
force-pushed
the
deprecate-query
branch
from
52eb8e0 to
bee6564
Compare
benvinegar
reviewed
Nov 29, 2016
| return this.captureException.apply(this, arguments); | ||
| }, | ||
| captureQuery: function captureQuery() { | ||
| utils.consoleAlert('captureQuery has been deprecated and will be removed in v2.0'); |
There was a problem hiding this comment.
will be removed
Doesn't this straight-up remove it? Why not keep the original implementation w/ this warning and remove in 2.0?
|
My understanding from a discussion with Cramer was that the
server/docs don't even know what query captures are anymore, so it's safe
to remove as long as it doesn't *break* existing code. If you think we
should keep the existing functionality for now, I'm fine with that.
|
benvinegar
approved these changes
Dec 2, 2016
LewisJEllis
added a commit
that referenced
this pull request
Dec 13, 2016
LewisJEllis
added a commit
that referenced
this pull request
Dec 13, 2016
LewisJEllis
added a commit
that referenced
this pull request
Dec 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @MaxBittker @benvinegar